Better trimming support + trimming fix #12785
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I made some tweaks to this, so I'm retesting locally. |
|
One question I had was why Tools.proj looks like this: I didn't disable trimming in this project yet. I think it might mean that the NuGetRepack pack will not get restored. Anyways, my main question is why this project explicitly sets a bunch of TFM properties. |
|
Just curious, where are these properties consumed? |
NikolaMilosavljevic
previously approved these changes
Mar 6, 2023
- Allow for trimming to be set in SourceBuild.props. This enables use in repo SB legs. Includes a default set which is all netcoreapps + netstandards. - Disable trimming for top level projects in Arcade, so that we don't accidentally skip things like publishing.
mmitche
force-pushed
the
better-trimming-support-and-fix
branch
from
e5fc7c2
to
3e255bb
Compare
|
@NikolaMilosavljevic Slight tweak here to the default TFM string (need re-approval). This did work in source build with it enabled to sdk +installer. |
src/Microsoft.DotNet.Arcade.Sdk/tools/SourceBuild/SourceBuildArcade.targets
Outdated
Show resolved
Hide resolved
NikolaMilosavljevic
approved these changes
Mar 6, 2023
This was referenced Mar 10, 2023
This was referenced Mar 17, 2023
This was referenced Mar 24, 2023
This was referenced Mar 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To double check: